Make some remaining X86 intrinsics safe #1908
Open
+174
−187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The prefetch intrinsics can also be made safe. |
|
It has a pointer parameter, can it still be made safe? Also, what about TSC, CPUID and the fence instructions? |
|
These intrinsics are all safe to call as long as the required target features are available. @rfcbot merge |
|
Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_mm512_reduce_mul_ph(missed)_bswap{,64}_mm_prefetch- It doesn't actually dereference the pointer argument, so it's safe_mm_{l,s,m}fence- These can't introduce inconsistencies, as they are fences._mm_pause- It's likestd::hint::spin_loop, so nothing unsafe here. Worst it can do is make the program slower